Re: [whatwg/dom] Allow passing null for customElementRegistry (PR #1386)

@smaug---- commented on this pull request.



> @@ -6598,7 +6598,7 @@ dictionary ShadowRootInit {
   SlotAssignmentMode slotAssignment = "named";
   boolean clonable = false;
   boolean serializable = false;
-  CustomElementRegistry customElementRegistry;
+  CustomElementRegistry? customElementRegistry = null;

Yeah, some comment would good, since this is a rather odd case. Wouldn't have guessed anyone using attachShadow that way, but don't see reason why not.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1386#discussion_r2176807119
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1386/review/2974172057@github.com>

Received on Tuesday, 1 July 2025 08:26:46 UTC