- From: Luke Warlow <notifications@github.com>
- Date: Thu, 03 Jul 2025 02:08:33 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 3 July 2025 09:09:12 UTC
@lukewarlow commented on this pull request. > + <li><p>If <var>attribute</var> is null, then set <var>attribute</var> to an <a>attribute</a> + whose <a for=Attr>local name</a> is <var>qualifiedName</var>, <a for=Attr>value</a> is + <var>value</var>, and <a for=Node>node document</a> is <a>this</a>'s <a for=Node>node document</a>. Apologies for the slow reply on here I thought I replied before but it must have got lost. TLDR: I agree with you I can't really remember why it's done this way. I updated the TT spec to just take the local name and namespace directly rather than an attribute object. As part of doing this change I realised these algorithms were overly complicated for what was actually needed. Hopefully now the integration points should be much cleaner and less invasive. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1268#discussion_r2182266785 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1268/review/2982370463@github.com>
Received on Thursday, 3 July 2025 09:09:12 UTC